Centralise hardcoded constants into named symbols#48
Merged
adrunkhuman merged 1 commit intomasterfrom Apr 12, 2026
Merged
Conversation
Fixes #31 — collects scattered magic values into one place: - internal/site/config.go: BaseURL, ArchiveURL, HTTPTimeout - internal/ui/commands.go: cmdTimeout (20s, stays near command layer) client.go and update.go now reference the named constants instead of inline literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/site/config.gowithBaseURL,ArchiveURL, andHTTPTimeoutto replace scattered magic strings and literals in the transport layer.cmdTimeoutininternal/ui/commands.go(kept near the command layer per the issue guidance) and replaces all 5 inline20*time.Secondliterals.client.goandupdate.gonow reference the named constants instead of inline literals.Fixes #31
Test plan
go build ./...— no import errors, all constants resolve correctly.go test ./...— all existing tests pass unchanged.